nifi-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [nifi] turcsanyip commented on a change in pull request #3843: phoenix dbcp service changes for Nifi-6054
Date Tue, 29 Oct 2019 19:39:49 GMT
turcsanyip commented on a change in pull request #3843: phoenix dbcp service changes for Nifi-6054
URL: https://github.com/apache/nifi/pull/3843#discussion_r340283316
 
 

 ##########
 File path: nifi-nar-bundles/nifi-standard-services/nifi-hbase_2-client-service-bundle/nifi-hbase_2-client-service/src/main/java/org/apache/nifi/hbase/phoenix/StandardPhoenixDBCPService.java
 ##########
 @@ -0,0 +1,196 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.hbase.phoenix;
+
+import java.sql.Connection;
+import java.sql.SQLException;
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.List;
+import java.util.Properties;
+import java.util.concurrent.TimeUnit;
+
+import org.apache.commons.dbcp.BasicDataSource;
+import org.apache.nifi.annotation.documentation.CapabilityDescription;
+import org.apache.nifi.annotation.documentation.Tags;
+import org.apache.nifi.annotation.lifecycle.OnDisabled;
+import org.apache.nifi.annotation.lifecycle.OnEnabled;
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.components.Validator;
+import org.apache.nifi.controller.AbstractControllerService;
+import org.apache.nifi.controller.ConfigurationContext;
+import org.apache.nifi.dbcp.DBCPService;
+import org.apache.nifi.expression.AttributeExpression;
+import org.apache.nifi.expression.ExpressionLanguageScope;
+import org.apache.nifi.processor.exception.ProcessException;
+import org.apache.nifi.processor.util.StandardValidators;
+import org.apache.nifi.reporting.InitializationException;
+import org.apache.phoenix.jdbc.PhoenixDriver;
+
+@Tags({ "phoenix", "DBCP", "hbase" })
+@CapabilityDescription("Create a phoenix DBCP connection pool.")
+public class StandardPhoenixDBCPService extends AbstractControllerService implements DBCPService
{
+
+    public static final PropertyDescriptor DATABASE_URL = new PropertyDescriptor.Builder()
+            .name("Database Connection URL")
+            .description(
+                    "A database connection URL used to connect to a database. May contain
database system name, host, port, database name and some parameters."
+                            + " The exact syntax of a database connection URL is specified
by your DBMS.")
+            .defaultValue(null).addValidator(StandardValidators.NON_EMPTY_VALIDATOR).required(true)
+            .expressionLanguageSupported(ExpressionLanguageScope.VARIABLE_REGISTRY).build();
+
+    public static final PropertyDescriptor DB_DRIVER_TYPE = new PropertyDescriptor.Builder()
+            .name("Phoenix Driver to use").description("Phoenix Driver to use").defaultValue("Thick")
+            .allowableValues("Thick", "Thin").required(true).addValidator(Validator.VALID).build();
+
+    public static final PropertyDescriptor DB_USER = new PropertyDescriptor.Builder().name("Database
User")
+            .description("Database user name").defaultValue(null).addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
+            .expressionLanguageSupported(ExpressionLanguageScope.VARIABLE_REGISTRY).build();
+
+    public static final PropertyDescriptor DB_PASSWORD = new PropertyDescriptor.Builder().name("Password")
+            .description("The password for the database user").defaultValue(null).required(false).sensitive(true)
+            .addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
+            .expressionLanguageSupported(ExpressionLanguageScope.VARIABLE_REGISTRY).build();
+
+    public static final PropertyDescriptor MAX_WAIT_TIME = new PropertyDescriptor.Builder().name("Max
Wait Time")
+            .description("The maximum amount of time that the pool will wait (when there
are no available connections) "
+                    + " for a connection to be returned before failing, or -1 to wait indefinitely.
")
+            .defaultValue("500 millis").required(true).addValidator(StandardValidators.TIME_PERIOD_VALIDATOR)
+            .sensitive(false).build();
+
+    public static final PropertyDescriptor MAX_TOTAL_CONNECTIONS = new PropertyDescriptor.Builder()
+            .name("Max Total Connections")
+            .description(
+                    "The maximum number of active connections that can be allocated from
this pool at the same time, "
+                            + " or negative for no limit.")
+            .defaultValue("8").required(true).addValidator(StandardValidators.INTEGER_VALIDATOR).sensitive(false)
+            .build();
+
+    public static final PropertyDescriptor VALIDATION_QUERY = new PropertyDescriptor.Builder().name("Validation-query")
+            .displayName("Validation query")
+            .description("Validation query used to validate connections before returning
them. "
+                    + "When connection is invalid, it get's dropped and new valid connection
will be returned. "
+                    + "Note!! Using validation might have some performance penalty.")
+            .required(false).addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
+            .expressionLanguageSupported(ExpressionLanguageScope.VARIABLE_REGISTRY).build();
+
+    private static final List<PropertyDescriptor> properties;
+
+    static {
+        final List<PropertyDescriptor> props = new ArrayList<>();
+        props.add(DATABASE_URL);
+        props.add(DB_DRIVER_TYPE);
+        props.add(DB_USER);
+        props.add(DB_PASSWORD);
+        props.add(MAX_WAIT_TIME);
+        props.add(MAX_TOTAL_CONNECTIONS);
+        props.add(VALIDATION_QUERY);
+
+        properties = Collections.unmodifiableList(props);
+    }
+
+    private volatile BasicDataSource dataSource;
+    // private volatile String dbUrl;
+
+    @Override
+    protected List<PropertyDescriptor> getSupportedPropertyDescriptors() {
+        return properties;
+    }
+
+    @Override
+    protected PropertyDescriptor getSupportedDynamicPropertyDescriptor(final String propertyDescriptorName)
{
+        return new PropertyDescriptor.Builder().name(propertyDescriptorName).required(false)
+                .addValidator(StandardValidators
+                        .createAttributeExpressionLanguageValidator(AttributeExpression.ResultType.STRING,
true))
+                .addValidator(StandardValidators.ATTRIBUTE_KEY_PROPERTY_NAME_VALIDATOR)
+                .expressionLanguageSupported(ExpressionLanguageScope.VARIABLE_REGISTRY).dynamic(true).build();
+    }
+
+    /**
+     * @param context
+     *            the configuration context
+     * @throws InitializationException
+     *             if unable to create a database connection
+     */
+    @OnEnabled
+    public void onEnabled(final ConfigurationContext context) throws InitializationException
{
+
+        final String drv = context.getProperty(DB_DRIVER_TYPE).evaluateAttributeExpressions().getValue();
+        final String user = context.getProperty(DB_USER).evaluateAttributeExpressions().getValue();
+        final String passw = context.getProperty(DB_PASSWORD).evaluateAttributeExpressions().getValue();
+        final Long maxWaitMillis = context.getProperty(MAX_WAIT_TIME).asTimePeriod(TimeUnit.MILLISECONDS);
+        final Integer maxTotal = context.getProperty(MAX_TOTAL_CONNECTIONS).asInteger();
+        final String validationQuery = context.getProperty(VALIDATION_QUERY).evaluateAttributeExpressions().getValue();
+        dataSource = new BasicDataSource();
+
+        Properties props = new Properties();
+
+        if ("Thick".equals(drv)) {
+            dataSource.setDriverClassName(PhoenixDriver.class.getName());
+        } else {
+            dataSource.setDriverClassName(PhoenixDriver.class.getName());
+        }
+        // driver=PhoenixDriver.class.getName();
+
+        // Optional driver URL, when exist, this URL will be used to locate
+        // driver jar file location
 
 Review comment:
   It seems to me an obsolete comment. `dburl` is the jdbc connection string, not the driver
jar url.
   The comment might have belonged to another code line.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message