nifi-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #657: MINIFICPP-1048 - Add PublishKafka docker tests
Date Thu, 17 Oct 2019 15:31:33 GMT
arpadboda commented on a change in pull request #657: MINIFICPP-1048 - Add PublishKafka docker
tests
URL: https://github.com/apache/nifi-minifi-cpp/pull/657#discussion_r336076913
 
 

 ##########
 File path: docker/test/integration/minifi/__init__.py
 ##########
 @@ -93,12 +96,22 @@ def deploy_flow(self,
         if self.network is None:
             net_name = 'nifi-' + str(uuid.uuid4())
             logging.info('Creating network: %s', net_name)
-            self.network = self.client.networks.create(net_name)
+            # Set IP
+            ipam_pool = docker.types.IPAMPool(
+                subnet='192.168.42.0/24',
 
 Review comment:
   Do you think it's going to work with whatever docker config developers may have?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message