nifi-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [nifi] adarmiento commented on a change in pull request #3700: NIFI-6638: Empty multiple queues at once at different flow levels
Date Thu, 10 Oct 2019 14:23:57 GMT
adarmiento commented on a change in pull request #3700: NIFI-6638: Empty multiple queues at
once at different flow levels
URL: https://github.com/apache/nifi/pull/3700#discussion_r333178439
 
 

 ##########
 File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core-api/src/main/java/org/apache/nifi/controller/queue/DropFlowFileRequest.java
 ##########
 @@ -30,13 +31,19 @@
     private DropFlowFileState state = DropFlowFileState.WAITING_FOR_LOCK;
 
 
-    public DropFlowFileRequest(final String identifier) {
-        this.identifier = identifier;
+    public DropFlowFileRequest(final String requestIdentifier,final String connectionIdentifier)
{
 
 Review comment:
   nit
   ```suggestion
       public DropFlowFileRequest(final String requestIdentifier, final String connectionIdentifier)
{
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message