nifi-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #635: MINIFICPP-819 - OPC Unified Architecture Support
Date Wed, 02 Oct 2019 00:41:44 GMT
arpadboda commented on a change in pull request #635: MINIFICPP-819 - OPC Unified Architecture
Support
URL: https://github.com/apache/nifi-minifi-cpp/pull/635#discussion_r330333855
 
 

 ##########
 File path: libminifi/include/Exception.h
 ##########
 @@ -41,12 +41,13 @@ enum ExceptionType {
   SITE2SITE_EXCEPTION,
   GENERAL_EXCEPTION,
   REGEX_EXCEPTION,
+  OPC_EXCEPTION,
   MAX_EXCEPTION
 };
 
 // Exception String 
 static const char *ExceptionStr[MAX_EXCEPTION] = { "File Operation", "Flow File Operation",
"Processor Operation", "Process Session Operation", "Process Schedule Operation", "Site2Site
Protocol",
-    "General Operation", "Regex Operation" };
+    "General Operation", "Regex Operation", "OPC Operation" };
 
 Review comment:
   I agree, there should be no pollution in the core. 
   
   I moved the exception to the extension, but it's not so nice as Exception class in MiNiFi
was not designed for being extended in any extension. (virtual functions? protected members?)
   
   Because of this I find your comment a bit belated and misguided. Should had been made by
the time such a class was designed. 
   
   This topic definitely worth a follow-up ticket,  I'm open to discussions, suggestions.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message