From issues-return-84107-archive-asf-public=cust-asf.ponee.io@nifi.apache.org Tue Sep 3 22:32:29 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id D9F6F180637 for ; Wed, 4 Sep 2019 00:32:28 +0200 (CEST) Received: (qmail 42261 invoked by uid 500); 4 Sep 2019 01:40:25 -0000 Mailing-List: contact issues-help@nifi.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@nifi.apache.org Delivered-To: mailing list issues@nifi.apache.org Received: (qmail 42242 invoked by uid 99); 4 Sep 2019 01:40:25 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 04 Sep 2019 01:40:25 +0000 From: GitBox To: issues@nifi.apache.org Subject: [GitHub] [nifi] scottyaslan commented on a change in pull request #3683: NIFI-6506 - Add ability to convert properties to parameters Message-ID: <156754994816.22201.9225420209775191463.gitbox@gitbox.apache.org> Date: Tue, 03 Sep 2019 22:32:28 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit scottyaslan commented on a change in pull request #3683: NIFI-6506 - Add ability to convert properties to parameters URL: https://github.com/apache/nifi/pull/3683#discussion_r320489059 ########## File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-parameter-contexts.js ########## @@ -1604,19 +1595,12 @@ text: '#ffffff' }, disabled: function () { - var input = $('#parameter-value-field'); - var isChecked = $('#parameter-set-empty-string-field').hasClass('checkbox-checked'); - var serializedValue = serializeValue(input, parameter, isChecked); - - var description = $('#parameter-description-field').val(); - - var hasChanged = serializedValue.hasChanged || description !== parameter.previousDescription; - - return !hasChanged; + var param = serializeParameter(parameter); + return !param.hasValueChanged && param.description === parameter.description; Review comment: ```suggestion return !param.hasValueChanged && param.hasDescriptionChanged; ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services