nifi-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #655: MINIFICPP-1049 - Fix make docker
Date Mon, 30 Sep 2019 22:56:02 GMT
arpadboda commented on a change in pull request #655: MINIFICPP-1049 - Fix make docker
URL: https://github.com/apache/nifi-minifi-cpp/pull/655#discussion_r329820874
 
 

 ##########
 File path: docker/DockerBuild.sh
 ##########
 @@ -57,3 +58,5 @@ DOCKER_COMMAND="docker build --build-arg UID=$UID_ARG \
                              apacheminificpp:$MINIFI_VERSION ."
 echo "Docker Command: '$DOCKER_COMMAND'"
 ${DOCKER_COMMAND}
+
+rm -rf $CMAKE_SOURCE_DIR/docker/minificppsource
 
 Review comment:
   What's the intent of doing it twice? 
   I'm fine with either doing cleanup at the start of the build or at end end, but don't get
the point of doing both.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message