nifi-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #648: WIP: Minificpp 1025 -- add metadata
Date Fri, 27 Sep 2019 15:40:17 GMT
arpadboda commented on a change in pull request #648: WIP: Minificpp 1025 -- add metadata
URL: https://github.com/apache/nifi-minifi-cpp/pull/648#discussion_r329127209
 
 

 ##########
 File path: extensions/windows-event-log/ConsumeWindowsEventLog.cpp
 ##########
 @@ -329,7 +404,14 @@ int ConsumeWindowsEventLog::processQueue(const std::shared_ptr<core::ProcessSess
     session->putAttribute(flowFile, FlowAttributeKey(MIME_TYPE), "application/xml");
     session->getProvenanceReporter()->receive(flowFile, provenanceUri_, getUUIDStr(),
"Consume windows event logs", 0);
     session->transfer(flowFile, Success);
-    session->commit();
+
+	flowFile = session->create();
+
+	session->write(flowFile, &WriteCallback(evt.rendered_text_));
+	session->putAttribute(flowFile, FlowAttributeKey(MIME_TYPE), "text/plain");
+	session->getProvenanceReporter()->receive(flowFile, provenanceUri_, getUUIDStr(),
"Consume windows event logs", 0);
+	session->transfer(flowFile, Success);
+	session->commit();
 
     flowFileCount++;
 
 Review comment:
   This is incorrect as we produce twice the amount, but that doesn't hurt as we ignore the
return value where this function is called. So the question is: do we need it at all? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message