nifi-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [nifi] scottyaslan commented on a change in pull request #3683: NIFI-6506 - Add ability to convert properties to parameters
Date Tue, 03 Sep 2019 22:32:28 GMT
scottyaslan commented on a change in pull request #3683: NIFI-6506 - Add ability to convert
properties to parameters
URL: https://github.com/apache/nifi/pull/3683#discussion_r320489059
 
 

 ##########
 File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-parameter-contexts.js
 ##########
 @@ -1604,19 +1595,12 @@
                                 text: '#ffffff'
                             },
                             disabled: function () {
-                                var input = $('#parameter-value-field');
-                                var isChecked = $('#parameter-set-empty-string-field').hasClass('checkbox-checked');
-                                var serializedValue = serializeValue(input, parameter, isChecked);
-
-                                var description = $('#parameter-description-field').val();
-
-                                var hasChanged = serializedValue.hasChanged || description
!== parameter.previousDescription;
-
-                                return !hasChanged;
+                                var param = serializeParameter(parameter);
+                                return !param.hasValueChanged && param.description
=== parameter.description;
 
 Review comment:
   ```suggestion
                                   return !param.hasValueChanged && param.hasDescriptionChanged;
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message