nifi-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [nifi-minifi-cpp] phrocker commented on a change in pull request #630: MINIFICPP-1006: minor updates for jni building using win build & correct artifact naming
Date Thu, 29 Aug 2019 18:33:50 GMT
phrocker commented on a change in pull request #630: MINIFICPP-1006: minor updates for jni
building using win build & correct artifact naming
URL: https://github.com/apache/nifi-minifi-cpp/pull/630#discussion_r319214222
 
 

 ##########
 File path: msi/WixWin.wsi
 ##########
 @@ -297,34 +316,58 @@
                                 ErrorControl="ignore"
                                 Start="auto"
                                 Interactive="no" />
-
+                <!--
                 <ServiceControl Id="ServiceControl_Start"
                       Name="Apache NiFi MiNiFi"
                       Start="install"
-                      Wait="no" />
+                      Wait="no" />-->
                 <ServiceControl Id="ServiceControl_Stop"
                                 Name="Apache NiFi MiNiFi"
                                 Stop="both"
                                 Remove="uninstall"
                                 Wait="yes" />
+                <Condition><![CDATA[SERVICEACCOUNT="LocalSystem"]]></Condition>
+              </Component>
+              <Component Id="minifiServiceNotLocal" Guid="87658309-0339-425c-8633-f54ffaaa4922">
+                <File Id="MiNiFiExeWithPassword"
+                         Name="minifi.exe"
+                         KeyPath="yes"
+                         Source="main\minifi.exe"/>
+                <ServiceInstall Id="MiNiFiExeServiceWithPassword"
+                                Type="ownProcess"
+                                Vital="yes"
+                                Name="Apache NiFi MiNiFi"
+                                DisplayName="Apache NiFi MiNiFi"
+                                Description="Apache NiFi MiNifi Service"
 
 Review comment:
   oh sorry this is also an old commit

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message