nifi-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [nifi-minifi-cpp] phrocker commented on a change in pull request #635: WIP: MINIFICPP-819 - OPC Unified Architecture Support
Date Wed, 28 Aug 2019 13:26:44 GMT
phrocker commented on a change in pull request #635: WIP: MINIFICPP-819 - OPC Unified Architecture
Support
URL: https://github.com/apache/nifi-minifi-cpp/pull/635#discussion_r318578787
 
 

 ##########
 File path: libminifi/include/core/Property.h
 ##########
 @@ -174,6 +174,11 @@ class Property {
   void addAllowedValue(const PropertyValue &value) {
     allowed_values_.push_back(value);
   }
+
+  void clearAllowedValues() {
 
 Review comment:
   Though, admittedly I wish they were completely immutable in Property/PropertyValue...but
that was a choice a much older decision. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message