nifi-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [nifi] joewitt commented on a change in pull request #3674: Nifi 6583
Date Tue, 27 Aug 2019 19:47:04 GMT
joewitt commented on a change in pull request #3674: Nifi 6583
URL: https://github.com/apache/nifi/pull/3674#discussion_r318264888
 
 

 ##########
 File path: nifi-nar-bundles/nifi-metrics-reporting-bundle/nifi-metrics-reporting-task/pom.xml
 ##########
 @@ -35,11 +35,32 @@
             <version>1.10.0-SNAPSHOT</version>
             <scope>provided</scope>
         </dependency>
+        <dependency>
 
 Review comment:
   i see quite a few new libraries added ( assuming there are also transitive libs pulled
).  Are all of these licenses known ?  They need to be reflect as per licensing guidance in
http://nifi.apache.org/licensing-guide.html so that they show up in our license/notice for
convenience binaries properly.  
   
   Given that this is Azure centric it might make sense to spin it into its own nar but since
it just expands on dropwizard as dep types maybe this is fine too.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message