nifi-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [nifi] alopresto commented on a change in pull request #3672: NIFI-6363 Additional Sensitive Property Providers
Date Tue, 27 Aug 2019 18:03:36 GMT
alopresto commented on a change in pull request #3672: NIFI-6363 Additional Sensitive Property
Providers
URL: https://github.com/apache/nifi/pull/3672#discussion_r318138072
 
 

 ##########
 File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-properties-loader/src/main/java/org/apache/nifi/properties/sensitive/aes/AESSensitivePropertyProvider.java
 ##########
 @@ -138,7 +146,7 @@ public String getName() {
      */
     @Override
     public String getIdentifierKey() {
-        return IMPLEMENTATION_KEY + getKeySize(Hex.toHexString(key.getEncoded()));
+        return IMPLEMENTATION_KEY + Hex.toHexString(key.getEncoded()); // getKeySize();
 
 Review comment:
   We should revert this to return `aes/gcm/128` rather than `aes/gcm/ABCDE...` with the hex-encoded
key material. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message