nifi-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [nifi] alopresto commented on a change in pull request #3672: NIFI-6363 Additional Sensitive Property Providers
Date Tue, 27 Aug 2019 18:03:36 GMT
alopresto commented on a change in pull request #3672: NIFI-6363 Additional Sensitive Property
Providers
URL: https://github.com/apache/nifi/pull/3672#discussion_r318128567
 
 

 ##########
 File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-properties-loader/src/main/java/org/apache/nifi/properties/sensitive/ProtectedNiFiProperties.java
 ##########
 @@ -72,10 +75,19 @@ public ProtectedNiFiProperties(NiFiProperties props) {
      *
      * @param rawProps the Properties to contain
      */
-    public ProtectedNiFiProperties(Properties rawProps) {
-        this(new StandardNiFiProperties(rawProps));
+    public ProtectedNiFiProperties(Properties rawProps, SensitivePropertyProvider sensitivePropertyProvider)
{
+        this(new StandardNiFiProperties(rawProps), sensitivePropertyProvider);
     }
 
+    public ProtectedNiFiProperties(NiFiProperties props, String keyOrKeyId) {
 
 Review comment:
   Add Javadoc for these two constructors explaining `keyOrKeyId`. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message