nifi-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [nifi] markap14 commented on a change in pull request #3559: NIFI-1624 Allow ExtractText processor to fail if max. capture group l…
Date Wed, 14 Aug 2019 20:01:55 GMT
markap14 commented on a change in pull request #3559: NIFI-1624 Allow ExtractText processor
to fail if max. capture group l…
URL: https://github.com/apache/nifi/pull/3559#discussion_r314053263
 
 

 ##########
 File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ExtractText.java
 ##########
 @@ -81,11 +86,17 @@
                 + "enabling repeating capture group is set to true. "
                 + "If any provided Regular Expression matches, the FlowFile(s) will be routed
to 'matched'. "
                 + "If no provided Regular Expression matches, the FlowFile will be routed
to 'unmatched' "
-                + "and no attributes will be applied to the FlowFile.")
+                + "and no attributes will be applied to the FlowFile."
 
 Review comment:
   Minor quibble: should add a space after the period, since the next line begins a new sentence.
Also should probably not capitalize 'FAILURE' relationship, since the name of the relationship
is 'failure' in lower case.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message