nifi-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [nifi] turcsanyip commented on a change in pull request #3601: NIFI-6468: Adding AWS S3 'requester pays' to Fetch and List processors.
Date Wed, 07 Aug 2019 15:49:29 GMT
turcsanyip commented on a change in pull request #3601: NIFI-6468: Adding AWS S3 'requester
pays' to Fetch and List processors.
URL: https://github.com/apache/nifi/pull/3601#discussion_r311629890
 
 

 ##########
 File path: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-abstract-processors/src/main/java/org/apache/nifi/processors/aws/s3/AbstractS3Processor.java
 ##########
 @@ -126,6 +126,15 @@
                     new AllowableValue("S3SignerType", "Signature v2"))
             .defaultValue("Default Signature")
             .build();
+    public static final PropertyDescriptor REQUESTER_PAYS = new PropertyDescriptor.Builder()
+            .name("requester-pays")
+            .displayName("Requester Pays")
+            .description("If set to 'True', the 'x-amz-request-payer' header will be set
to 'requester', indicating that you agree to pay S3 bucket request "
+                     + " charges.  Note that this is not supported when listing object versions.")
+            .required(true)
 
 Review comment:
   Sorry, I overlooked the validator you added (could you please use additional commits next
time?).
   That validator works too.
   `customValidate()` is just more common for validating multiple properties and in that way
the REQUESTER_PAYS property could be defined once in the abstract class.
   Anyway, this solution also fine with me.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message