nifi-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [nifi] AxelSync commented on issue #3600: NIFI-6420 Controller Service references not properly tracked if multiple references from same component
Date Thu, 25 Jul 2019 16:55:40 GMT
AxelSync commented on issue #3600: NIFI-6420 Controller Service references not properly tracked
if multiple references from same component
URL: https://github.com/apache/nifi/pull/3600#issuecomment-515123090
 
 
   @mgaido91 I am checking out the `StandardSchedulingContext` and it seems it is not used
anywhere in the codebase, the same happens for its method `leaseControllerService`, which
is also empty in other `SchedulingContext` implementations. 
   
   Taking a look at the history of the project, I see the `StandardSchedulingContext` is in
the codebase from the very beginning in 2014, and after some small modifications of 2016 and
2018, it got completely unused after the `StatelessProcessContext` (formerly `FnProcessContext`)
was introduced (NIFI-5922). 
   It seems to me this is a leftover from previous implementations, could we maybe delete
it in further PR? 
   
   cc @markap14 @bbende could you please confirm or give me your thoughts about this? Thank
you
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message