nifi-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [nifi] ijokarumawak commented on a change in pull request #3504: NIFI-6318: Support EL in CSV formatting properties
Date Fri, 19 Jul 2019 04:31:31 GMT
ijokarumawak commented on a change in pull request #3504: NIFI-6318: Support EL in CSV formatting
properties
URL: https://github.com/apache/nifi/pull/3504#discussion_r305181764
 
 

 ##########
 File path: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi/csv/CSVReader.java
 ##########
 @@ -134,6 +145,13 @@ public RecordReader createRecordReader(final Map<String, String>
variables, fina
         final RecordSchema schema = getSchema(variables, new NonCloseableInputStream(in),
null);
         in.reset();
 
+        CSVFormat csvFormat;
+        if (!CSVUtils.isDynamicCSVFormat(context)) {
 
 Review comment:
   Since `this.csvFormat` is the result of `CSVUtils.isDynamicCSVFormat()`, we can replace
this if statement to a simpler one:
   ```
           if (!this.csvFormat != null) {
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message