nifi-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [nifi-minifi-cpp] bakaid commented on a change in pull request #610: MINIFICPP-814 - Fixed ListenHTTP and HTTPClient bugs, created tests f…
Date Tue, 16 Jul 2019 10:08:20 GMT
bakaid commented on a change in pull request #610: MINIFICPP-814 - Fixed ListenHTTP and HTTPClient
bugs, created tests f…
URL: https://github.com/apache/nifi-minifi-cpp/pull/610#discussion_r303828360
 
 

 ##########
 File path: extensions/civetweb/tests/resources/generate.sh
 ##########
 @@ -0,0 +1,53 @@
+#!/bin/sh
 
 Review comment:
   The script is included for reproducibility and for easier understanding of how the certs
were created (it could be deduced from looking at the PEM files, but that would take quite
some time).
   I agree that at least parts of this code (the functions) could be made into a generic tool
(which this script can then include), but the certs generated here are specific to this test
set.
   However, I am not sure where we should place such code and whether we would really use
it.
   I think this might be worth revisiting if the need for test certs arise in the future.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message