nifi-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [nifi] avseq1234 commented on a change in pull request #3575: NIFI-6271, fix incoming flowfile attributes don't copy into output flowfiles when Output Batch Size is set
Date Wed, 10 Jul 2019 00:43:09 GMT
avseq1234 commented on a change in pull request #3575: NIFI-6271, fix incoming flowfile attributes
don't copy into output flowfiles when Output Batch Size is set
URL: https://github.com/apache/nifi/pull/3575#discussion_r301847285
 
 

 ##########
 File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/AbstractExecuteSQL.java
 ##########
 @@ -312,12 +312,6 @@ public void onTrigger(final ProcessContext context, final ProcessSession
session
                                 // If we've reached the batch size, send out the flow files
                                 if (outputBatchSize > 0 && resultSetFlowFiles.size()
>= outputBatchSize) {
                                     session.transfer(resultSetFlowFiles, REL_SUCCESS);
-                                    // Need to remove the original input file if it exists
-                                    if (fileToProcess != null) {
-                                        session.remove(fileToProcess);
-                                        fileToProcess = null;
-                                    }
-                                    session.commit();
 
 Review comment:
   I modify the code because the way that I mentioned before will break some test.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message