nifi-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [nifi] markap14 commented on a change in pull request #3553: NIFI-5856: When exporting a flow that references a Controller Service…
Date Mon, 08 Jul 2019 19:12:50 GMT
markap14 commented on a change in pull request #3553: NIFI-5856: When exporting a flow that
references a Controller Service…
URL: https://github.com/apache/nifi/pull/3553#discussion_r301257118
 
 

 ##########
 File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/NiFiServiceFacade.java
 ##########
 @@ -1359,13 +1360,16 @@
      * @param registryId the ID of the Flow Registry to persist the snapshot to
      * @param flow the flow where the snapshot should be persisted
      * @param snapshot the Snapshot to persist
+     * @param externalControllerServiceReferences a mapping of controller service id to ExternalControllerServiceReference
for any Controller Service that is referenced in the flow but not included
+     * in the VersionedProcessGroup
      * @param comments about the snapshot
      * @param expectedVersion the version to save the flow as
      * @return the snapshot that represents what was stored in the registry
      *
      * @throws NiFiCoreException if unable to register the snapshot with the flow registry
      */
-    VersionedFlowSnapshot registerVersionedFlowSnapshot(String registryId, VersionedFlow
flow, VersionedProcessGroup snapshot, String comments, int expectedVersion);
+    VersionedFlowSnapshot registerVersionedFlowSnapshot(String registryId, VersionedFlow
flow, VersionedProcessGroup snapshot,
 
 Review comment:
   That should be fine. From the NiFi perspective, we are only reading. We are writing to
the NiFi Registry.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message