nifi-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [nifi] markap14 commented on a change in pull request #3553: NIFI-5856: When exporting a flow that references a Controller Service…
Date Mon, 08 Jul 2019 18:16:57 GMT
markap14 commented on a change in pull request #3553: NIFI-5856: When exporting a flow that
references a Controller Service…
URL: https://github.com/apache/nifi/pull/3553#discussion_r301234354
 
 

 ##########
 File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/NiFiServiceFacade.java
 ##########
 @@ -2156,6 +2160,16 @@ ControllerServiceReferencingComponentsEntity updateControllerServiceReferencingC
      */
     void discoverCompatibleBundles(VersionedProcessGroup versionedGroup);
 
+    /**
+     * For any Controller Service that is found in the given Versioned Process Group, if
that Controller Service is not itself included in the Versioned Process Groups,
+     * attempts to find an existing Controller Service that matches the definition. If any
is found, the component within the Versioned Process Group is updated to point
+     * to the existing service.
+     *
+     * @param versionedFlowSnapshot the flow snapshot
+     * @param parentGroupId the ID of the Process Group from which the Controller Services
are inherited
+     */
+    void resolveInheritedControllerServices(VersionedFlowSnapshot versionedFlowSnapshot,
String parentGroupId);
 
 Review comment:
   Good catch. Will address.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message