nifi-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [nifi-minifi-cpp] bakaid commented on a change in pull request #596: MINIFICPP-925 - Fix TailFile hang on long lines
Date Wed, 26 Jun 2019 10:29:00 GMT
bakaid commented on a change in pull request #596: MINIFICPP-925 - Fix TailFile hang on long
lines
URL: https://github.com/apache/nifi-minifi-cpp/pull/596#discussion_r297595189
 
 

 ##########
 File path: libminifi/test/pcap-tests/CMakeLists.txt
 ##########
 @@ -29,17 +29,17 @@ FOREACH(testfile ${PCAP_TESTS})
   	target_include_directories(${testfilename} PRIVATE BEFORE "${CMAKE_BINARY_DIR}/extensions/pcap/pcap++/Dist/header/")
     createTests("${testfilename}")
     if(APPLE)    
-    	target_link_libraries ("${testfilename}" -Wl,-all_load minifi-pcap )
 
 Review comment:
   Yes, I did, it fails on the `assert(LogTestController::getInstance().contains("Accepting
") == true && LogTestController::getInstance().contains("because it matches .*") );`
assertion.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message