nifi-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [nifi] alopresto commented on a change in pull request #3495: NIFI-5973 Adds ShellUserGroupProvider
Date Wed, 05 Jun 2019 04:32:43 GMT
alopresto commented on a change in pull request #3495: NIFI-5973 Adds ShellUserGroupProvider
URL: https://github.com/apache/nifi/pull/3495#discussion_r290560675
 
 

 ##########
 File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-shell-authorizer/src/main/java/org/apache/nifi/authorization/OsxShellCommands.java
 ##########
 @@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.authorization;
+
+class OsxShellCommands implements ShellCommandsProvider {
+    public String getUsersList() {
 
 Review comment:
   I don't think this command is correct, as on my local Mac OS X 10.14 system, this returns:

   
   ```
   # username:uid
   alopresto:502
   ...
   nobody:-2
   root:0
   ```
   while I believe the expected format is:
   
   ```
   # username:uid:gid_of_primary_group
   alopresto:502:20
   ...
   nobody:-2:-2
   root:0:0
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message