From issues-return-63882-archive-asf-public=cust-asf.ponee.io@nifi.apache.org Tue Sep 4 04:29:03 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 1A90E180647 for ; Tue, 4 Sep 2018 04:29:02 +0200 (CEST) Received: (qmail 93164 invoked by uid 500); 4 Sep 2018 02:29:02 -0000 Mailing-List: contact issues-help@nifi.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@nifi.apache.org Delivered-To: mailing list issues@nifi.apache.org Received: (qmail 93154 invoked by uid 99); 4 Sep 2018 02:29:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 04 Sep 2018 02:29:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id AF6A31A1BCA for ; Tue, 4 Sep 2018 02:29:01 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.301 X-Spam-Level: X-Spam-Status: No, score=-110.301 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id z9erdk33ncu3 for ; Tue, 4 Sep 2018 02:29:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id CB3CF5F382 for ; Tue, 4 Sep 2018 02:29:00 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 5DA63E0D9F for ; Tue, 4 Sep 2018 02:29:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 1946E23F98 for ; Tue, 4 Sep 2018 02:29:00 +0000 (UTC) Date: Tue, 4 Sep 2018 02:29:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@nifi.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (NIFI-5569) Add tags to Route* processors for discoverability MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/NIFI-5569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16602554#comment-16602554 ] ASF GitHub Bot commented on NIFI-5569: -------------------------------------- Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/2984#discussion_r214774007 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/RouteText.java --- @@ -655,14 +653,9 @@ public boolean equals(Object obj) { Group other = (Group) obj; if (capturedValues == null) { - if (other.capturedValues != null) { - return false; - } - } else if (!capturedValues.equals(other.capturedValues)) { - return false; - } + return other.capturedValues == null; + } else return capturedValues.equals(other.capturedValues); --- End diff -- This was an automatic IDE optimization I wasn't aware of, but the logic checks out. > Add tags to Route* processors for discoverability > ------------------------------------------------- > > Key: NIFI-5569 > URL: https://issues.apache.org/jira/browse/NIFI-5569 > Project: Apache NiFi > Issue Type: Improvement > Components: Documentation & Website > Affects Versions: 1.7.1 > Reporter: Andy LoPresto > Assignee: Andy LoPresto > Priority: Trivial > Labels: beginner, documentation, keyword, label > > In a fit of forgetfulness, I could not remember the {{RouteOn*}} processors when trying to detect the presence of some bytes in flowfile content. I propose adding the keywords "find", "search", "scan", and "detect" to the following processors, as they are used for those functions but do not come up in a search for those keywords. > * {{RouteOnAttribute}} > * {{RouteOnContent}} > * {{RouteText}} > Additionally, {{ScanContent}} and {{ReplaceText}} can have additional keywords added to improve discoverability. -- This message was sent by Atlassian JIRA (v7.6.3#76005)