nifi-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (NIFI-5569) Add tags to Route* processors for discoverability
Date Tue, 04 Sep 2018 02:29:00 GMT

    [ https://issues.apache.org/jira/browse/NIFI-5569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16602554#comment-16602554
] 

ASF GitHub Bot commented on NIFI-5569:
--------------------------------------

Github user alopresto commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2984#discussion_r214774007
  
    --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/RouteText.java
---
    @@ -655,14 +653,9 @@ public boolean equals(Object obj) {
     
                 Group other = (Group) obj;
                 if (capturedValues == null) {
    -                if (other.capturedValues != null) {
    -                    return false;
    -                }
    -            } else if (!capturedValues.equals(other.capturedValues)) {
    -                return false;
    -            }
    +                return other.capturedValues == null;
    +            } else return capturedValues.equals(other.capturedValues);
    --- End diff --
    
    This was an automatic IDE optimization I wasn't aware of, but the logic checks out. 


> Add tags to Route* processors for discoverability
> -------------------------------------------------
>
>                 Key: NIFI-5569
>                 URL: https://issues.apache.org/jira/browse/NIFI-5569
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Documentation &amp; Website
>    Affects Versions: 1.7.1
>            Reporter: Andy LoPresto
>            Assignee: Andy LoPresto
>            Priority: Trivial
>              Labels: beginner, documentation, keyword, label
>
> In a fit of forgetfulness, I could not remember the {{RouteOn*}} processors when trying
to detect the presence of some bytes in flowfile content. I propose adding the keywords "find",
"search", "scan", and "detect" to the following processors, as they are used for those functions
but do not come up in a search for those keywords. 
> * {{RouteOnAttribute}}
> * {{RouteOnContent}}
> * {{RouteText}}
> Additionally, {{ScanContent}} and {{ReplaceText}} can have additional keywords added
to improve discoverability. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message