nifi-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (NIFI-5239) Make MongoDBControllerService able to act as a configuration source for MongoDB processors
Date Mon, 17 Sep 2018 04:08:00 GMT


ASF GitHub Bot commented on NIFI-5239:

Github user zenfenan commented on a diff in the pull request:
    --- Diff: nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-services/src/main/java/org/apache/nifi/mongodb/
    @@ -17,156 +17,162 @@
     package org.apache.nifi.mongodb;
    -import com.mongodb.client.FindIterable;
    +import com.mongodb.MongoClient;
    +import com.mongodb.MongoClientOptions;
    +import com.mongodb.MongoClientURI;
    +import com.mongodb.WriteConcern;
     import com.mongodb.client.MongoCollection;
    -import com.mongodb.client.MongoCursor;
     import com.mongodb.client.MongoDatabase;
    -import com.mongodb.client.model.UpdateOptions;
    +import org.apache.commons.lang3.StringUtils;
     import org.apache.nifi.annotation.documentation.CapabilityDescription;
     import org.apache.nifi.annotation.documentation.Tags;
     import org.apache.nifi.annotation.lifecycle.OnDisabled;
     import org.apache.nifi.annotation.lifecycle.OnEnabled;
    +import org.apache.nifi.annotation.lifecycle.OnStopped;
    +import org.apache.nifi.authentication.exception.ProviderCreationException;
    +import org.apache.nifi.components.PropertyDescriptor;
    +import org.apache.nifi.controller.AbstractControllerService;
     import org.apache.nifi.controller.ConfigurationContext;
    -import org.apache.nifi.reporting.InitializationException;
    +import org.apache.nifi.ssl.SSLContextService;
     import org.bson.Document;
     import java.util.ArrayList;
     import java.util.List;
     @Tags({"mongo", "mongodb", "service"})
         "Provides a controller service that wraps most of the functionality of the MongoDB
    -public class MongoDBControllerService extends AbstractMongoDBControllerService implements
MongoDBClientService {
    +public class MongoDBControllerService extends AbstractControllerService implements MongoDBClientService
    --- End diff --
    If possible, I would be +1 for a controller service with a better name. I'm not saying
`MongoDBControllerService` is a bad name but a name that rhymes with functionality that this
controller service offers would sound even better. something like `MongoDBClientProvider`
or something.

> Make MongoDBControllerService able to act as a configuration source for MongoDB processors
> ------------------------------------------------------------------------------------------
>                 Key: NIFI-5239
>                 URL:
>             Project: Apache NiFi
>          Issue Type: New Feature
>            Reporter: Mike Thomsen
>            Assignee: Mike Thomsen
>            Priority: Major
> The MongoDBControllerService should be able to provide the getDatabase and getCollection
functionality that are built into the MongoDB processors through AbstractMongoDBProcessor.
Using the controller service with the processors should be optional in the first release it's
added and then mandatory going forward.

This message was sent by Atlassian JIRA

View raw message