nifi-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From alopresto <...@git.apache.org>
Subject [GitHub] nifi pull request #2984: NIFI-5569 Added keywords to Route* and ScanAttribut...
Date Tue, 04 Sep 2018 02:28:02 GMT
Github user alopresto commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2984#discussion_r214774007
  
    --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/RouteText.java
---
    @@ -655,14 +653,9 @@ public boolean equals(Object obj) {
     
                 Group other = (Group) obj;
                 if (capturedValues == null) {
    -                if (other.capturedValues != null) {
    -                    return false;
    -                }
    -            } else if (!capturedValues.equals(other.capturedValues)) {
    -                return false;
    -            }
    +                return other.capturedValues == null;
    +            } else return capturedValues.equals(other.capturedValues);
    --- End diff --
    
    This was an automatic IDE optimization I wasn't aware of, but the logic checks out. 


---

Mime
View raw message