Mailing-List: contact issues-help@nifi.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@nifi.apache.org
Date: Fri, 11 Aug 2017 07:53:00 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@nifi.apache.org
Message-ID: <JIRA.13091841.1501668367000.8607.1502437980417@Atlassian.JIRA>
In-Reply-To: <JIRA.13091841.1501668367000@Atlassian.JIRA>
References: <JIRA.13091841.1501668367000@Atlassian.JIRA> <JIRA.13091841.1501668367497@jira-lw-us.apache.org>
Subject: [jira] [Commented] (NIFI-4257) Allow a custom WHERE clause in
 AbstractDatabaseFetchProcessor
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Fri, 11 Aug 2017 07:53:05 -0000


    [ https://issues.apache.org/jira/browse/NIFI-4257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16122989#comment-16122989 ] 

ASF GitHub Bot commented on NIFI-4257:
--------------------------------------

Github user pvillard31 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2050#discussion_r132631612
  
    --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/GenerateTableFetch.java ---
    @@ -259,6 +261,11 @@ public void onTrigger(final ProcessContext context, final ProcessSessionFactory
                     }
                 });
     
    +            if(customWhereClause != null) {
    +                // adding the custom WHERE clause (if defined) to the list of existing clauses.
    +                maxValueClauses.add(customWhereClause);
    --- End diff --
    
    Yes @patricker, that makes sense, will push a commit for that. Thanks!


> Allow a custom WHERE clause in AbstractDatabaseFetchProcessor
> -------------------------------------------------------------
>
>                 Key: NIFI-4257
>                 URL: https://issues.apache.org/jira/browse/NIFI-4257
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Extensions
>            Reporter: Pierre Villard
>            Assignee: Pierre Villard
>
> It could be useful allowing a user to set a custom WHERE clause in AbstractDatabaseFetchProcessor in case not all of the data in the table is required.
> In case the WHERE clause is changed after the processor has already been running, the user will probably have to set the initial maximum values to ensure the expected behaviour.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)