nifi-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (NIFI-4218) ElasticsearchHttp processors should support dynamic properties as query parameters
Date Wed, 02 Aug 2017 13:43:00 GMT

    [ https://issues.apache.org/jira/browse/NIFI-4218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16110919#comment-16110919
] 

ASF GitHub Bot commented on NIFI-4218:
--------------------------------------

GitHub user mattyb149 opened a pull request:

    https://github.com/apache/nifi/pull/2049

    NIFI-4218: Dynamic properties as query parameters in ESHttp processors

    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying
to resolve? Pay particular attention to the hyphen "-" character.
    
    - [x] Has your PR been rebased against the latest commit within the target branch (typically
master)?
    
    - [x] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check
clean install at the root nifi folder?
    - [x] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way
that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file
under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file
found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic
access) for each of the new properties?
    
    ### For documentation related changes:
    - [x] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mattyb149/nifi NIFI-4218

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/2049.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2049
    
----
commit e6fe6dc3adc953b5eea938e0750efe38f92b88ab
Author: Matt Burgess <mattyb149@apache.org>
Date:   2017-08-02T13:41:12Z

    NIFI-4218: Dynamic properties as query parameters in ESHttp processors

----


> ElasticsearchHttp processors should support dynamic properties as query parameters
> ----------------------------------------------------------------------------------
>
>                 Key: NIFI-4218
>                 URL: https://issues.apache.org/jira/browse/NIFI-4218
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Extensions
>            Reporter: Matt Burgess
>            Assignee: Matt Burgess
>            Priority: Minor
>
> The Elasticsearch HTTP API has a number of fields that can be specified as query parameters
in the URL, such as support for [pipelines|https://www.elastic.co/guide/en/elasticsearch/reference/current/ingest.html].
Rather than including all possibilities as processor properties, it might be more flexible
to allow the user to specify dynamic properties on ElasticsearchHttp processors, and then
use those to set query parameters on the API URL.
> Documentation should include a note that not all features are available to all versions
of Elasticsearch, and thus the ES documentation should be consulted before adding dynamic
properties. For example, pipelines were introduced in ES 5.x, so using pipeline parameters
in an ElasticsearchHttp processor will not work if connecting to an ES 2.x cluster.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message