nifi-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James Wing (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (NIFI-4215) Avro schemas with records that have a field of themselves fail to parse, causing stackoverflow exception
Date Thu, 03 Aug 2017 04:28:00 GMT

    [ https://issues.apache.org/jira/browse/NIFI-4215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16112166#comment-16112166
] 

James Wing commented on NIFI-4215:
----------------------------------

[~markap14], would you please expand a bit on the immutability concern and what criteria we
should apply to a solution?  Although the changes we introduced would mutate the SimpleRecordSchema
once after creation, I don't believe it would have introduced or permitted widespread updates
outside the initial creation and configuration.  Are you worried about immediate multi-threaded
changes we introduced, future developers abusing the access, or the JVM not performing the
right optimizations without the benefit of {{final}} guidance?

> Avro schemas with records that have a field of themselves fail to parse, causing stackoverflow
exception
> --------------------------------------------------------------------------------------------------------
>
>                 Key: NIFI-4215
>                 URL: https://issues.apache.org/jira/browse/NIFI-4215
>             Project: Apache NiFi
>          Issue Type: Bug
>    Affects Versions: 1.4.0
>            Reporter: Wesley L Lawrence
>            Priority: Minor
>         Attachments: nifi-4215.patch
>
>
> Noticed this while attempting to use the AvroSchemaRegsitry with some complex schema.
Boiled down, Avro lets you define a schema such as;
> {code}
> { 
>   "namespace": "org.apache.nifi.testing", 
>   "name": "CompositRecord", 
>   "type": "record", 
>   "fields": [ 
>     { 
>       "name": "id", 
>       "type": "int" 
>     }, 
>     { 
>       "name": "value", 
>       "type": "string" 
>     }, 
>     { 
>       "name": "parent", 
>       "type": [
>         "null",
>         "CompositRecord"
>       ]
>     } 
>   ] 
> }
> {code}
> The AvroSchemaRegistry (AvroTypeUtil specifically) will fail to parse, and generate a
stackoverflow exception.
> I've whipped up a fix, tested it out in 1.4.0, and am just running through the contrib
build before I submit a patch.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message