nifi-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James Wing (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (NIFI-4215) Avro schemas with records that have a field of themselves fail to parse, causing stackoverflow exception
Date Wed, 02 Aug 2017 04:57:01 GMT

    [ https://issues.apache.org/jira/browse/NIFI-4215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16110305#comment-16110305
] 

James Wing commented on NIFI-4215:
----------------------------------

Thanks, [~markap14] , for bringing these issues to our attention.

I pushed a new commit to revert this change so it is not blocking, and we can take the time
to make the right fix.

[~WesleyLawrence], I think the builder approach is worth a look, although I also haven't figured
out the chicken vs. egg schema creation with a builder.  I like that part of your solution.

> Avro schemas with records that have a field of themselves fail to parse, causing stackoverflow
exception
> --------------------------------------------------------------------------------------------------------
>
>                 Key: NIFI-4215
>                 URL: https://issues.apache.org/jira/browse/NIFI-4215
>             Project: Apache NiFi
>          Issue Type: Bug
>    Affects Versions: 1.4.0
>            Reporter: Wesley L Lawrence
>            Priority: Blocker
>             Fix For: 1.4.0
>
>         Attachments: nifi-4215.patch
>
>
> Noticed this while attempting to use the AvroSchemaRegsitry with some complex schema.
Boiled down, Avro lets you define a schema such as;
> {code}
> { 
>   "namespace": "org.apache.nifi.testing", 
>   "name": "CompositRecord", 
>   "type": "record", 
>   "fields": [ 
>     { 
>       "name": "id", 
>       "type": "int" 
>     }, 
>     { 
>       "name": "value", 
>       "type": "string" 
>     }, 
>     { 
>       "name": "parent", 
>       "type": [
>         "null",
>         "CompositRecord"
>       ]
>     } 
>   ] 
> }
> {code}
> The AvroSchemaRegistry (AvroTypeUtil specifically) will fail to parse, and generate a
stackoverflow exception.
> I've whipped up a fix, tested it out in 1.4.0, and am just running through the contrib
build before I submit a patch.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message