nifi-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From patricker <...@git.apache.org>
Subject [GitHub] nifi pull request #2091: NIFI-3484 GenerateTableFetch Should Allow for Right...
Date Fri, 18 Aug 2017 03:19:10 GMT
Github user patricker commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2091#discussion_r133872895
  
    --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/GenerateTableFetch.java
---
    @@ -112,6 +112,17 @@
                 .addValidator(StandardValidators.NON_NEGATIVE_INTEGER_VALIDATOR)
                 .build();
     
    +    public static final PropertyDescriptor RIGHT_BOUND_WHERE = new PropertyDescriptor.Builder()
    --- End diff --
    
    I am OK with proceeding that way, though I'd feel better if I knew how many databases
this has been tested on. When I wrote it my focus was on one, relatively uncommon (SAP HANA)
system. It tests out fine, but I just worry about making it the default.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message