nifi-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mans2singh <...@git.apache.org>
Subject [GitHub] nifi issue #2045: NIFI-4250 - Elasticsearch 5 delete processor
Date Sat, 12 Aug 2017 23:18:52 GMT
Github user mans2singh commented on the issue:

    https://github.com/apache/nifi/pull/2045
  
    @mattyb149 
    
    Regarding having a separate delete processor - I prefer single responsibility principle
since it avoids confusion and mixing up configuration, processing logic, error handling, testing,
maintenance etc.  Along the same lines ElasticSearch provides separate JAVA delete/put/get
request builders.  Besides, overloading put and delete is confusing to me from the REST semantics.
    
    Let me know your thoughts.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message