nifi-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From alopresto <...@git.apache.org>
Subject [GitHub] nifi issue #2044: NIFI-4139 Extract key provider to framework-level service
Date Sat, 05 Aug 2017 01:37:11 GMT
Github user alopresto commented on the issue:

    https://github.com/apache/nifi/pull/2044
  
    I also considered passing a supplier rather than the master key to the `KeyProviderFactory`,
but the `EncryptedWriteAheadProvenanceRepository` already has access to the master key retrieval
code, so I didn't yet. 
    
    I also considered making a DTO for the `KeyProvider` configuration values used in the
factory, as the parameter list is getting a little long, but the only place they are currently
used is in the EWAPR. When I implement NIFI-3888 subtasks for content and flowfile repository,
I may refactor this to be more concise.  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message