nifi-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mcgilman <...@git.apache.org>
Subject [GitHub] nifi issue #2044: NIFI-4139 Extract key provider to framework-level service
Date Fri, 04 Aug 2017 13:58:20 GMT
Github user mcgilman commented on the issue:

    https://github.com/apache/nifi/pull/2044
  
    @alopresto These refactorings look good. The backward compatibility support for legacy
configurations is also solid. One minor thing I'd like to investigate further if we can remove
the dependency between the nifi-security-utils and the nifi-properties-loader. The nifi-security-utils
are referenced and pulled into many NARs and the additional dependency would introduce further
duplication of the nifi-properties-loader jar (and it's transitive dependencies not already
included). This dependency is only used to load the master key from the bootstrap.conf. While
it's not a showstopper, it would be nice if we didn't need this additional dependency and
instead allowed the client of the nifi-security-utils provide the master key when necessary.
    
    Thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message