nifi-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jvwing <...@git.apache.org>
Subject [GitHub] nifi pull request #1888: NIFI-4015 NIFI-3999 Fix DeleteSQS Issues
Date Tue, 01 Aug 2017 04:19:10 GMT
Github user jvwing commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/1888#discussion_r130516693
  
    --- Diff: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/test/java/org/apache/nifi/processors/aws/sqs/ITDeleteSQS.java
---
    @@ -0,0 +1,83 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.nifi.processors.aws.sqs;
    +
    +import java.io.File;
    +import java.io.IOException;
    +import java.util.HashMap;
    +import java.util.Map;
    +
    +import com.amazonaws.regions.Regions;
    +import com.amazonaws.services.sqs.model.Message;
    +import com.amazonaws.services.sqs.model.ReceiveMessageResult;
    +import com.amazonaws.services.sqs.model.SendMessageResult;
    +import org.apache.nifi.util.TestRunner;
    +import org.apache.nifi.util.TestRunners;
    +
    +import com.amazonaws.auth.PropertiesCredentials;
    +import com.amazonaws.services.sqs.AmazonSQSClient;
    +
    +import org.junit.Before;
    +import org.junit.Ignore;
    +import org.junit.Test;
    +
    +import static org.junit.Assert.assertEquals;
    +
    +
    +@Ignore("For local testing only - interacts with S3 so the credentials file must be configured
and all necessary queues created")
    +public class ITDeleteSQS {
    +
    +    private final String CREDENTIALS_FILE = System.getProperty("user.home") + "/aws-credentials.properties";
    --- End diff --
    
    @jzonthemtn The DeleteSQS processor can absolutely use default credentials through a controller
service.  The integration tests across the SQS processors and most of the AWS bundle use a
properties file, and I followed that pattern.  I'm not sure if it was desired as the best
solution, or just the one we knew how to use at the time.  Maybe it prevents people from accidentally
running the integration tests on with their default credentials?
    
    What do you think?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message