Mailing-List: contact issues-help@nifi.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@nifi.apache.org
Date: Mon, 6 Feb 2017 14:12:41 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@nifi.apache.org
Message-ID: <JIRA.13040624.1486385450000.5717.1486390361629@Atlassian.JIRA>
In-Reply-To: <JIRA.13040624.1486385450000@Atlassian.JIRA>
References: <JIRA.13040624.1486385450000@Atlassian.JIRA> <JIRA.13040624.1486385450836@jira-lw-us.apache.org>
Subject: [jira] [Commented] (NIFI-3442) FTPTransfer tries to evaluate PORT
 as expression language, although property doesn't support EL
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Mon, 06 Feb 2017 14:12:50 -0000


    [ https://issues.apache.org/jira/browse/NIFI-3442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15854054#comment-15854054 ] 

ASF GitHub Bot commented on NIFI-3442:
--------------------------------------

GitHub user trixpan opened a pull request:

    https://github.com/apache/nifi/pull/1474

    NIFI-3442 - Explictly support EL on Username, password, port

                Introduce basic test unit
    
    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [X] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [X] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [X] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [X] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [X] Have you written or updated unit tests to verify your changes?
    - [X] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [X] ~~If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?~~
    - [X] ~~If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?~~
    - [X] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [X] ~~Have you ensured that format looks appropriate for the output in which it is rendered?~~
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/trixpan/nifi NIFI-3442

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/1474.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1474
    
----
commit df06b07387d7ba0b3cacc340117957400fc9a42e
Author: Andre F de Miranda <trixpan@users.noreply.github.com>
Date:   2017-02-06T13:21:27Z

    NIFI-3442 - Explictly support EL on Username, password, port
                Introduce basic test unit

----


> FTPTransfer tries to evaluate PORT as expression language, although property doesn't support EL
> -----------------------------------------------------------------------------------------------
>
>                 Key: NIFI-3442
>                 URL: https://issues.apache.org/jira/browse/NIFI-3442
>             Project: Apache NiFi
>          Issue Type: Bug
>    Affects Versions: 0.7.1, 1.1.1
>            Reporter: Andre
>            Assignee: Andre
>
> while crafting test coverage for PutFTP I noticed the following error:
> java.lang.AssertionError: java.lang.IllegalStateException: Attempting to Evaluate Expressions but PropertyDescriptor[Port] indicates that the Expression Language is not supported. If you realize that this is the case and do not want this error to occur, it can be disabled by calling TestRunner.setValidateExpressionUsage(false)
> Root cause seems to be a disconnect between the property builder (EL = false) and the attempt  to evaluate the property as part of client.connect


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)