Mailing-List: contact issues-help@nifi.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@nifi.apache.org
Date: Thu, 2 Feb 2017 01:38:51 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@nifi.apache.org
Message-ID: <JIRA.12852305.1438795037000.13416.1485999531525@Atlassian.JIRA>
In-Reply-To: <JIRA.12852305.1438795037000@Atlassian.JIRA>
References: <JIRA.12852305.1438795037000@Atlassian.JIRA> <JIRA.12852305.1438795037662@jira-lw-us.apache.org>
Subject: [jira] [Commented] (NIFI-819) Allow specification of headers for
 GetHTTP
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Thu, 02 Feb 2017 01:38:58 -0000


    [ https://issues.apache.org/jira/browse/NIFI-819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15849251#comment-15849251 ] 

ASF GitHub Bot commented on NIFI-819:
-------------------------------------

Github user trixpan commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/1462#discussion_r99038321
  
    --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/GetHTTP.java ---
    @@ -467,6 +486,18 @@ public void onTrigger(final ProcessContext context, final ProcessSessionFactory
                 if (accept != null) {
                     get.addHeader(HEADER_ACCEPT, accept);
                 }
    +
    +            // Add dynamic headers
    +
    +            PropertyValue customHeaderValue;
    +            for (PropertyDescriptor customProperty : customHeaders) {
    +                customHeaderValue = context.getProperty(customProperty).evaluateAttributeExpressions();
    --- End diff --
    
    I considered that but refrained from it due to:
    
    https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/GetHTTP.java#L99


> Allow specification of headers for GetHTTP
> ------------------------------------------
>
>                 Key: NIFI-819
>                 URL: https://issues.apache.org/jira/browse/NIFI-819
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Extensions
>    Affects Versions: 0.2.1
>            Reporter: Aldrin Piri
>            Assignee: Andre
>            Priority: Minor
>             Fix For: 1.2.0
>
>
> There is currently no way to provide additional headers for requests through GetHTTP.  Some endpoints may require a token or other information to access information.  Currently, it is possible to work around this with an InvokeHttp driven by a dummy file, but interpretation of dynamic properties added as additional headers would provide a better option.


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)