From issues-return-18963-apmail-nifi-issues-archive=nifi.apache.org@nifi.apache.org Wed Feb 1 14:48:18 2017 Return-Path: X-Original-To: apmail-nifi-issues-archive@minotaur.apache.org Delivered-To: apmail-nifi-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3EC2719AFD for ; Wed, 1 Feb 2017 14:48:18 +0000 (UTC) Received: (qmail 95319 invoked by uid 500); 1 Feb 2017 14:48:18 -0000 Delivered-To: apmail-nifi-issues-archive@nifi.apache.org Received: (qmail 95290 invoked by uid 500); 1 Feb 2017 14:48:18 -0000 Mailing-List: contact issues-help@nifi.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@nifi.apache.org Delivered-To: mailing list issues@nifi.apache.org Received: (qmail 95281 invoked by uid 99); 1 Feb 2017 14:48:18 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Feb 2017 14:48:18 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 0F521DFBDB; Wed, 1 Feb 2017 14:48:18 +0000 (UTC) From: mattyb149 To: issues@nifi.apache.org Reply-To: issues@nifi.apache.org Message-ID: Subject: [GitHub] nifi pull request #1461: NIFI-3426: Add dynamic property support to DBCPConn... Content-Type: text/plain Date: Wed, 1 Feb 2017 14:48:18 +0000 (UTC) GitHub user mattyb149 opened a pull request: https://github.com/apache/nifi/pull/1461 NIFI-3426: Add dynamic property support to DBCPConnectionPool Unit test adds "create=true" as a Derby property (instead of via the URL), written in Groovy to leverage the recursive deleteDir() method. If the create property is not set, the test fails. ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [x] Have you written or updated unit tests to verify your changes? - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [x] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [x] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [x] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/mattyb149/nifi dyn_jdbc_props Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/1461.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1461 ---- commit 3b8eeeb18604496fc48960cd89b10a5fecc05053 Author: Matt Burgess Date: 2017-02-01T14:45:21Z NIFI-3426: Add dynamic property support to DBCPConnectionPool ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---