nifi-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (NIFI-3434) nifi-assembly dependencies should allow users to skip the creation of ZIP and TAR.GZ packages
Date Fri, 03 Feb 2017 11:56:51 GMT

    [ https://issues.apache.org/jira/browse/NIFI-3434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15851393#comment-15851393
] 

ASF GitHub Bot commented on NIFI-3434:
--------------------------------------

GitHub user trixpan opened a pull request:

    https://github.com/apache/nifi/pull/1472

    NIFI-3434 - Introduce the ability to skip the packaging of zip and ta…

    …r.gz archive via maven profile (i.e. -Pdir-only)
    
    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying
to resolve? Pay particular attention to the hyphen "-" character.
    
    - [x] Has your PR been rebased against the latest commit within the target branch (typically
master)?
    
    - [x] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check
clean install at the root nifi folder?
    - [x] ~~Have you written or updated unit tests to verify your changes?~~
    - [x] ~~If adding new dependencies to the code, are these dependencies licensed in a way
that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
~~
    - [x] ~~If applicable, have you updated the LICENSE file, including the main LICENSE file
under nifi-assembly?~~
    - [x] ~~If applicable, have you updated the NOTICE file, including the main NOTICE file
found under nifi-assembly?~~
    - [x] ~~If adding new Properties, have you added .displayName in addition to .name (programmatic
access) for each of the new properties?~~
    
    ### For documentation related changes:
    - [x] ~~Have you ensured that format looks appropriate for the output in which it is rendered?~~
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/trixpan/nifi NIFI-3434

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/1472.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1472
    
----
commit 3d38205d44b5bd34d6f17082facad8bd6dafeac7
Author: Andre F de Miranda <trixpan@users.noreply.github.com>
Date:   2017-02-03T11:51:55Z

    NIFI-3434 - Introduce the ability to skip the packaging of zip and tar.gz archive
                via maven profile (i.e. -Pdir-only)

----


> nifi-assembly dependencies should allow users to skip the creation of ZIP and TAR.GZ
packages
> ---------------------------------------------------------------------------------------------
>
>                 Key: NIFI-3434
>                 URL: https://issues.apache.org/jira/browse/NIFI-3434
>             Project: Apache NiFi
>          Issue Type: Improvement
>    Affects Versions: 1.1.1
>            Reporter: Andre
>            Assignee: Andre
>
> devs,
> Currently calling 'mvn clean install' creates a ZIP, a TAR.GZ and a
> directory containing the same code. This leads to wasted disk space and a
> lot of wasted disk writes (something that a lot of folks using SSDs prefer
> to avoid).
> Would anyone oppose the idea of moving the ZIP and TAR.GZ assemblies into a
> "release" profile (or whatever name we agree to). This way we could
> maintain the directory "format" (which I suspect most of us use during
> development), while still providing a convenient way of creating the ZIP
> and TAR.GZ packages.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message