nifi-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (NIFI-3427) Data Provenance date/time sort ignores the date
Date Thu, 02 Feb 2017 04:03:51 GMT

    [ https://issues.apache.org/jira/browse/NIFI-3427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15849372#comment-15849372
] 

ASF GitHub Bot commented on NIFI-3427:
--------------------------------------

GitHub user jvwing opened a pull request:

    https://github.com/apache/nifi/pull/1465

    NIFI-3427 Fix Provenance DateTime Sorting

    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [X] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying
to resolve? Pay particular attention to the hyphen "-" character.
    
    - [X] Has your PR been rebased against the latest commit within the target branch (typically
master)?
    
    - [X] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [X] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check
clean install at the root nifi folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way
that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file
under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file
found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic
access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible.
    
    ---
    
    Fixing nf.Common.parseDateTime to use month 0 - 11 instead of 1 - 12. Although dates produced
by parseDateTime are used for sorting, getting the month off by one results in inconsistent
relative sorting when the months are not of the same length (January 31st becomes March 3rd).
  parseDateTime is used beyond the provenance table that started the ticket, it is also used
in Templates dialog sorting, Add Template dialog sorting, and Cluster dialog sorting.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jvwing/nifi NIFI-3427-provenance-datetime-sort-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/1465.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1465
    
----
commit da6d916b145161085552ebaf8cb6b0321a94bbc8
Author: James Wing <jvwing@gmail.com>
Date:   2017-02-02T01:52:28Z

    NIFI-3427 Fix Provenance DateTime Sorting

----


> Data Provenance date/time sort ignores the date
> -----------------------------------------------
>
>                 Key: NIFI-3427
>                 URL: https://issues.apache.org/jira/browse/NIFI-3427
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Core UI
>    Affects Versions: 1.1.1
>            Reporter: Justin Rittenhouse
>            Assignee: James Wing
>            Priority: Minor
>         Attachments: Screen Shot 2017-02-01 at 9.49.11 AM.png
>
>
> The Data provenance display window that pops up doesn't properly sort by date/time. 
It sorts by time, with events dated 11pm from January 31 appearing before/after (depending
on ascending or descending sort) events dated February 1 before 11pm.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message