nifi-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (NIFI-3426) Add ability to set JDBC properties via dynamic properties in DBCPConnectionPool
Date Wed, 01 Feb 2017 14:48:51 GMT


ASF GitHub Bot commented on NIFI-3426:

GitHub user mattyb149 opened a pull request:

    NIFI-3426: Add dynamic property support to DBCPConnectionPool

    Unit test adds "create=true" as a Derby property (instead of via the URL), written in
Groovy to leverage the recursive deleteDir() method. If the create property is not set, the
test fails.
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    - [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying
to resolve? Pay particular attention to the hyphen "-" character.
    - [x] Has your PR been rebased against the latest commit within the target branch (typically
    - [x] Is your initial contribution a single, squashed commit?
    ### For code changes:
    - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check
clean install at the root nifi folder?
    - [x] Have you written or updated unit tests to verify your changes?
    - [x] If adding new dependencies to the code, are these dependencies licensed in a way
that is compatible for inclusion under [ASF 2.0](

    - [x] If applicable, have you updated the LICENSE file, including the main LICENSE file
under nifi-assembly?
    - [x] If applicable, have you updated the NOTICE file, including the main NOTICE file
found under nifi-assembly?
    - [x] If adding new Properties, have you added .displayName in addition to .name (programmatic
access) for each of the new properties?
    ### For documentation related changes:
    - [x] Have you ensured that format looks appropriate for the output in which it is rendered?
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible.

You can merge this pull request into a Git repository by running:

    $ git pull dyn_jdbc_props

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1461
commit 3b8eeeb18604496fc48960cd89b10a5fecc05053
Author: Matt Burgess <>
Date:   2017-02-01T14:45:21Z

    NIFI-3426: Add dynamic property support to DBCPConnectionPool


> Add ability to set JDBC properties via dynamic properties in DBCPConnectionPool
> -------------------------------------------------------------------------------
>                 Key: NIFI-3426
>                 URL:
>             Project: Apache NiFi
>          Issue Type: Improvement
>            Reporter: Matt Burgess
>            Assignee: Matt Burgess
>            Priority: Minor
> Although many JDBC drivers allow for the setting of connection-specific properties via
the JDBC URL, some JDBC drivers only accept specific configuration properties for a connection
via programmatic calls to add properties to the Connection object; those same properties will
not be parsed from the URL.
> In general, a proposed improvement is to add support for Dynamic Properties to the DBCPConnectionPool
controller service. Each dynamic property would be set as a property on the DataSource when
the controller service is enabled. Note that Expression Language can be supported, but as
no flow file will be available at enable-time, flow file attributes cannot be used in EL expressions.
However the Variable Registry could be leveraged to provide different values in different
environments (dev, test, production, e.g.).

This message was sent by Atlassian JIRA

View raw message