nifi-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (NIFI-3408) Add an attribute for failure reason to InvokeHTTP in all cases to match docs
Date Thu, 02 Feb 2017 15:58:51 GMT


ASF GitHub Bot commented on NIFI-3408:

GitHub user gglanzani opened a pull request:

    NIFI-3408 Add exception class when InvokeHTTP fails

    I think this closes the Jira ticket. I couldn't execute (all) the tests as an SMTP tests
fails on Windows (in my machine at least), but it fails on the master branch and on release
1.1.0 and 1.0.0 so I guess it's not due to the changes below.
    I also have not added tests related to this. The test suite in nifi-standard-processors
seemed quite thin, I'm probably missing something.
    Disclaimer: I'm a data scientist that writes Python. I'm more than willing to learn (and
help!) if things are not how they should be.

You can merge this pull request into a Git repository by running:

    $ git pull master

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1467


> Add an attribute for failure reason to InvokeHTTP in all cases to match docs
> ----------------------------------------------------------------------------
>                 Key: NIFI-3408
>                 URL:
>             Project: Apache NiFi
>          Issue Type: Improvement
>            Reporter: Joseph Percivall
>            Priority: Minor
> Originally brought up on the mailing list[1], the InvokeHTTP docs state:
> ```
> The original FlowFile will be routed on any type of connection failure, timeout or general
exception. It will have new attributes detailing the request.
> ```
> Adding attributes currently only happens though when a response is received from the
server, so not attributes if it fails to connect or the socket times out.
> These attributes should be added.
> [1]

This message was sent by Atlassian JIRA

View raw message