nifi-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (NIFI-3355) nifi.web.http(s).host set to breaks request replication when clustered
Date Tue, 14 Feb 2017 21:30:41 GMT


ASF GitHub Bot commented on NIFI-3355:

Github user jtstorck commented on a diff in the pull request:
    --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-jetty/src/main/java/org/apache/nifi/web/server/
    @@ -569,17 +572,43 @@ private void configureConnectors(final Server server) throws ServerConfiguration
       "Configuring Jetty for HTTP on port: " + port);
    -            // create the connector
    -            final ServerConnector http = new ServerConnector(server, new HttpConnectionFactory(httpConfiguration));
    +            final List<Connector> serverConnectors = Lists.newArrayList();
    -            // set host and port
    -            if (StringUtils.isNotBlank(props.getProperty(NiFiProperties.WEB_HTTP_HOST)))
    -                http.setHost(props.getProperty(NiFiProperties.WEB_HTTP_HOST));
    +            final Map<String, String> httpNetworkInterfaces = props.getHttpNetworkInterfaces();
    +            if (httpNetworkInterfaces.isEmpty()) {
    --- End diff --
    This needs to be expanded to check that the map is empty, or that there are no actual
values for any of the keys in the map.  As it stands, if the properties for binding to a NIC
are absent from the config, this code works...  But if a property exists but is left blank,
this if block would get skipped, it'd go into the else block, and end up not creating any

> nifi.web.http(s).host set to breaks request replication when clustered
> ------------------------------------------------------------------------------
>                 Key: NIFI-3355
>                 URL:
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Core Framework
>    Affects Versions: 1.0.0, 1.1.0, 1.1.1, 1.0.1
>            Reporter: Jeff Storck
>            Assignee: Jeff Storck
> The value of nifi.web.http(s).host is used as the node's address (combined with the configured
port) and is the address used for request replication.  When nodes are clustered, and
is used to bind Jetty to all network interfaces, requests are replicated to (for
example) and are unable to be completed.

This message was sent by Atlassian JIRA

View raw message