nifi-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (NIFI-819) Allow specification of headers for GetHTTP
Date Thu, 02 Feb 2017 01:33:51 GMT

    [ https://issues.apache.org/jira/browse/NIFI-819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15849240#comment-15849240
] 

ASF GitHub Bot commented on NIFI-819:
-------------------------------------

Github user apiri commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/1462#discussion_r99036818
  
    --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/GetHTTP.java
---
    @@ -467,6 +486,18 @@ public void onTrigger(final ProcessContext context, final ProcessSessionFactory
                 if (accept != null) {
                     get.addHeader(HEADER_ACCEPT, accept);
                 }
    +
    +            // Add dynamic headers
    +
    +            PropertyValue customHeaderValue;
    +            for (PropertyDescriptor customProperty : customHeaders) {
    +                customHeaderValue = context.getProperty(customProperty).evaluateAttributeExpressions();
    --- End diff --
    
    I could see this potentially making use of the incoming FlowFile as seed data for the
EL.  Perhaps we should pass in the flowFile?


> Allow specification of headers for GetHTTP
> ------------------------------------------
>
>                 Key: NIFI-819
>                 URL: https://issues.apache.org/jira/browse/NIFI-819
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Extensions
>    Affects Versions: 0.2.1
>            Reporter: Aldrin Piri
>            Assignee: Andre
>            Priority: Minor
>             Fix For: 1.2.0
>
>
> There is currently no way to provide additional headers for requests through GetHTTP.
 Some endpoints may require a token or other information to access information.  Currently,
it is possible to work around this with an InvokeHttp driven by a dummy file, but interpretation
of dynamic properties added as additional headers would provide a better option.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message