nifi-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From qfdk <...@git.apache.org>
Subject [GitHub] nifi pull request #1376: NIFI-3268 Add AUTO_INCREMENT column in GenerateTabl...
Date Tue, 14 Feb 2017 23:31:36 GMT
Github user qfdk commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/1376#discussion_r101170880
  
    --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/GenerateTableFetch.java
---
    @@ -87,6 +87,18 @@
                 .addValidator(StandardValidators.NON_NEGATIVE_INTEGER_VALIDATOR)
                 .build();
     
    +    public static final PropertyDescriptor AUTO_INCREMENT_KEY = new PropertyDescriptor.Builder()
    +            .name("gen-table-fetch-partition-index")
    +            .displayName("AUTO_INCREMENT(index) column name")
    +            .description("The column has AUTO_INCREMENT attribute and index."
    +                    + "If there is a column with AUTO_INCREMENT property and index in
the database, we can use index instead of using OFFSET."
    +                    + "The value must start by 1")
    +            .defaultValue("null")
    +            .addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
    +            .required(true)
    --- End diff --
    
    I agree with you. I will change it 👍 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message