nifi-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jtstorck <...@git.apache.org>
Subject [GitHub] nifi pull request #1508: NIFI-3355 Allows NiFi to bind to specific network i...
Date Tue, 14 Feb 2017 21:32:19 GMT
Github user jtstorck commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/1508#discussion_r101148418
  
    --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-jetty/src/main/java/org/apache/nifi/web/server/JettyServer.java
---
    @@ -590,28 +619,59 @@ private void configureConnectors(final Server server) throws ServerConfiguration
     
                 logger.info("Configuring Jetty for HTTPs on port: " + port);
     
    -            // add some secure config
    -            final HttpConfiguration httpsConfiguration = new HttpConfiguration(httpConfiguration);
    -            httpsConfiguration.setSecureScheme("https");
    -            httpsConfiguration.setSecurePort(props.getSslPort());
    -            httpsConfiguration.addCustomizer(new SecureRequestCustomizer());
    +            final List<Connector> serverConnectors = Lists.newArrayList();
     
    -            // build the connector
    -            final ServerConnector https = new ServerConnector(server,
    -                    new SslConnectionFactory(createSslContextFactory(), "http/1.1"),
    -                    new HttpConnectionFactory(httpsConfiguration));
    +            final Map<String, String> httpsNetworkInterfaces = props.getHttpsNetworkInterfaces();
    +            if (httpsNetworkInterfaces.isEmpty()) {
    --- End diff --
    
    The following comment from line 578 applies here as well. [https://github.com/apache/nifi/pull/1508/commits/88520369d910dff61892b86841dc9eab28bf03e3#r101147915](url)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message