nifi-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mattyb149 <...@git.apache.org>
Subject [GitHub] nifi pull request #1471: NIFI-3432 Handle Multiple Result Sets in ExecuteSQL
Date Tue, 14 Feb 2017 16:31:33 GMT
Github user mattyb149 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/1471#discussion_r101078853
  
    --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestExecuteSQL.java
---
    @@ -222,7 +222,10 @@ public void testWithSqlException() throws SQLException {
             runner.setProperty(ExecuteSQL.SQL_SELECT_QUERY, "SELECT val1 FROM TEST_NO_ROWS");
             runner.run();
     
    -        runner.assertAllFlowFilesTransferred(ExecuteSQL.REL_FAILURE, 1);
    +        //No incoming flow file containing a query, and an exception causes no outbound
flowfile.
    +        // There should be no flow files on either relatationship
    +        runner.assertTransferCount(ExecuteSQL.REL_FAILURE, 0);
    +        runner.assertTransferCount(ExecuteSQL.REL_FAILURE, 0);
    --- End diff --
    
    These are identical, I'm guessing one should be REL_SUCCESS?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message