nifi-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jvwing <...@git.apache.org>
Subject [GitHub] nifi pull request #1482: NIFI-3449: Adding GCP Framework and GCS Processors
Date Fri, 10 Feb 2017 06:05:10 GMT
Github user jvwing commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/1482#discussion_r100471403
  
    --- Diff: nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/credentials/factory/strategies/AbstractBooleanCredentialsStrategy.java
---
    @@ -0,0 +1,62 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.nifi.processors.gcp.credentials.factory.strategies;
    +
    +import org.apache.nifi.components.PropertyDescriptor;
    +import org.apache.nifi.components.ValidationContext;
    +import org.apache.nifi.components.ValidationResult;
    +import org.apache.nifi.processors.gcp.credentials.factory.CredentialsStrategy;
    +
    +import java.util.ArrayList;
    +import java.util.Collection;
    +
    +
    +/**
    + * Partial implementation of CredentialsStrategy to provide support for credential strategies
specified by
    + * a single boolean property.
    + */
    +public abstract class AbstractBooleanCredentialsStrategy extends AbstractCredentialsStrategy
{
    --- End diff --
    
    I think we need an override for `canCreatePrimaryCredential()` that parses the boolean
property value.  As-is, I believe it fails in the following scenario:
    1. Create a GCPCredentialsControllerService
    2. Edit properties to set "Use Application Default Credentials" to `true`.  Click Apply.
    3. Edit properties to set "Use Application Default Credentials" to `false`, and "Use Compute
Engine Credentials" to `true`.  Click Apply.
    The controller service is now in an invalid state because "Use Application Default Credentials"
thinks it's in a viable state with a non-null property value, without parsing the property
to understand "false" means no.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message