nifi-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jvwing <...@git.apache.org>
Subject [GitHub] nifi pull request #1482: NIFI-3449: Adding GCP Framework and GCS Processors
Date Fri, 10 Feb 2017 06:05:10 GMT
Github user jvwing commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/1482#discussion_r100472194
  
    --- Diff: nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/storage/StorageAttributes.java
---
    @@ -0,0 +1,98 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.nifi.processors.gcp.storage;
    +
    +
    +/**
    + * Common attributes being written and accessed through Google Cloud Storage.
    + */
    +public class StorageAttributes {
    +    private StorageAttributes() {}
    +
    +    public static final String BUCKET_ATTR = "gcs.bucket";
    +    public static final String BUCKET_DESC = "Bucket of the object.";
    +
    +    public static final String KEY_ATTR = "gcs.key";
    +    public static final String KEY_DESC = "Name of the object.";
    +
    +    public static final String SIZE_ATTR = "gcs.size";
    +    public static final String SIZE_DESC = "Size of the object.";
    +
    +    public static final String CACHE_CONTROL_ATTR = "gcs.cache.control";
    +    public static final String CACHE_CONTROL_DESC = "Data cache control of the object.";
    +
    +    public static final String COMPONENT_COUNT_ATTR = "gcs.component.count";
    +    public static final String COMPONENT_COUNT_DESC = "The number of components which
make up the object.";
    +
    +    public static final String CONTENT_DISPOSITION_ATTR = "gcs.content.disposition";
    +    public static final String CONTENT_DISPOSITION_DESC = "The data content disposition
of the object.";
    +
    +    public static final String CONTENT_ENCODING_ATTR = "gcs.content.encoding";
    +    public static final String CONTENT_ENCODING_DESC = "The content encoding of the object.";
    +
    +    public static final String CONTENT_LANGUAGE_ATTR = "gcs.content.language";
    +    public static final String CONTENT_LANGUAGE_DESC = "The content language of the object.";
    +
    +    public static final String CONTENT_TYPE_ATTR = "gcs.content.type";
    --- End diff --
    
    Did you consider using `mime.type` here?  It is a mostly-standardized NiFi attribute for
content types, widely used by other processors.  See [CoreAttributes](https://github.com/apache/nifi/blob/master/nifi-commons/nifi-utils/src/main/java/org/apache/nifi/flowfile/attributes/CoreAttributes.java).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message